Fix CPP on Instances.TH.Lift import #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents a build error with GHC 8.10.1 and 8.10.2 which bundle
text-1.2.3.2:
src/Nix/Expr/Types.hs:497:21: error:
• Could not deduce (TH.Lift Text) arising from a use of ‘TH.lift’
from the context: Data b
bound by a type expected by the context:
forall b. Data b => b -> Maybe (TH.Q TH.Exp)
at src/Nix/Expr/Types.hs:(490,7)-(498,7)
or from: b ~ Text
bound by a pattern with constructor:
HRefl :: forall k1 (a :: k1). a :~~: a,
in a pattern binding in
a 'do' block
at src/Nix/Expr/Types.hs:493:11-15
• In the expression: TH.lift b
In the first argument of ‘pure’, namely
‘[| $(TH.lift b) |]
pending(rn) [<splice, TH.lift b>]’
In a stmt of a 'do' block:
pure
[| $(TH.lift b) |]
pending(rn) [<splice, TH.lift b>]
|
497 | pure [| $(TH.lift b) |]
| ^^^^^^^^^
|
Thank you. |
|
Yes. How did you know this stuff? ;) |
|
@sjakobi: Published HNix so far can not give GHC 9.0, the work upstream comes next to allow it. After that the release would be made just to provide GHC support. |
|
Thanks for the bug fix release @Anton-Latukha! :) I just happened to see the build failure on the Hackage matrix page and then figured it out after looking at https://gitlab.haskell.org/ghc/ghc/-/wikis/commentary/libraries/version-history and the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents a build error with GHC 8.10.1 and 8.10.2 which bundle
text-1.2.3.2:
I had noticed the build failure in the Hackage build matrix: https://matrix.hackage.haskell.org/#/package/hnix/0.13.0/ghc-8.10.1@1620752895